It's a good point. I think I'll have to include that in the one about "what you should do when code reviewing."
For time-sake, I usually only run the code if I need to. But I have a coworker who almost always pulls down the code and their feedback is super on point
Great post, reminds me how important soft skills are in software engineering
Thank you, Ryan! Yep, I wish there was some better education around this especially for folks like myself who I feel I'm a bit awkward and unusual 😂
Same 😅, “how to win friends and influence people” was the best thing I found. Title is a little weird but tldr it’s a good book about soft skills
Haha yeah, I actually read that right before college but I think a refresher is always good and you always pick up new things
What not to say in reviews. Kiwi edition.
https://twitter.com/rickysullivan/status/1626017850296250372?s=20
haha thats good
I notice you didn't mention anything about running the actual code. Do you include that in your code reviews?
It's a good point. I think I'll have to include that in the one about "what you should do when code reviewing."
For time-sake, I usually only run the code if I need to. But I have a coworker who almost always pulls down the code and their feedback is super on point
One more tip is to introduce a practice to mention the severity in the pr. Most of times we are not sure of that and keep the review for later.
Yes, exactly! Great callout Prudhvi. Thank you :)