I find these advises good if you are in N. American company and N.American team. But the moment you have international team, you quickly realize that indirect feedback doesn't work with people who prefer direct feedback. To understand the subject, I recommend the book Culture Map.
Also, don't forget that code review is a review of the CODE, not the AUTHOR of the code. If both sides agree on that, then it's much easier to give effective concise feedback in code reviews.
Thanks for this article Jordan! I loved the "What vs. Why" tip. I think on top of this, it's also helpful to use "we" instead of "you" in communication. It's important to establish that both the Author and Reviewer are on the same team at the end of the day.
Incredible content as usual, resonates much with the insights we've recently gotten from Roojuta Lalani (Staff SWE at Slack). Saving the list of empathizing words to use: though I don't do many code reviews, they're pretty useful in any kind of feedback :)
I realized sometimes I need to think more than twice when I would like to get a fair balance about my intended message and the way how it is delivered. This is great for that.
I loved the What vs why tip, never thought about it!
Great article Jordan 🙏
I find these advises good if you are in N. American company and N.American team. But the moment you have international team, you quickly realize that indirect feedback doesn't work with people who prefer direct feedback. To understand the subject, I recommend the book Culture Map.
Also, don't forget that code review is a review of the CODE, not the AUTHOR of the code. If both sides agree on that, then it's much easier to give effective concise feedback in code reviews.
Thanks for this article Jordan! I loved the "What vs. Why" tip. I think on top of this, it's also helpful to use "we" instead of "you" in communication. It's important to establish that both the Author and Reviewer are on the same team at the end of the day.
Great
It's super important to make sure the other person understands your comments is about the code, not about their ability as engineers.
I like using https://conventionalcomments.org/
Many times even the simplest question leaves people wondering:
- Is this a genuine question?
- Do they see something why it's wrong and I don't know why?
- ...
By stating if you are making a suggestion or you see an issue, you remove that overthinking :)
Incredible content as usual, resonates much with the insights we've recently gotten from Roojuta Lalani (Staff SWE at Slack). Saving the list of empathizing words to use: though I don't do many code reviews, they're pretty useful in any kind of feedback :)
Great recommendations!
I realized sometimes I need to think more than twice when I would like to get a fair balance about my intended message and the way how it is delivered. This is great for that.
I love too the “What vs. Why”.
And the emphatizing words vs. descriptive words”.
Awesome read !
This made me lol literally.
Lol